Dev - Fixed the loss of fort data#2241
Dev - Fixed the loss of fort data#2241SamuraiKal wants to merge 4 commits intoPokemonGoF:devfrom SamuraiKal:dev
Conversation
| forts = [] | ||
| wild_pokemons = [] | ||
| catchable_pokemons = [] | ||
| fortspresent = False |
There was a problem hiding this comment.
Do you really need this flag? Could we just check for len(forts)?
There was a problem hiding this comment.
Tried that first, it threw a get_item error.
|
Also fix conflicts with dev branch, please. |
|
@Abraxas000 One way to separate commits is (or remove commits from that branch) is using |
|
Thanks all for the assistance! I'm used to using TFS so I'm still bumbling my way through the git processes. @TheSavior The cluster change has been reverted and the conflict from the previous merge is resolved. |
|
This PR got very messy. I'm starting with a fresh fork and branching my edits so I won't have to deal with this again later. I'm sure there's a more elegant way to clean up my forked repo, but I've already spent too long trying to fix this xD |
|
New PR: #2269 |
Short Description: This fixes loss of fort data when the server returns no fort data.
It seems like the server is saving cycles/bandwidth by only returning fort data when there has been a change to forts in your cells. When it returns no forts, we currently replace our existing data with the empty data. This fixes that so we keep our fort data if the server returned no fort data. Wild/lured pokemon are still updated in any case.
Fixes:
Known related Issues:
-#2184