Update MoveToMapPokemon to use events instead of logger (similar to #2867)#2881
Update MoveToMapPokemon to use events instead of logger (similar to #2867)#2881chrisle wants to merge 64 commits intoPokemonGoF:devfrom chrisle:dev
Conversation
chrisle
changed the title
|
This is better than mine 👍 |
|
maybe a squash and a rebase is in order, i can't apply this cleanly |
|
I was just realizing that actually. Hold on. |
| # Move To map pokemon | ||
| self.event_manager.register_event( | ||
| 'move_to_map_pokemon_fail', | ||
| parameters=('message') |
There was a problem hiding this comment.
this needs to be ('message',), otherwise the tuple isn't valid
|
👍 @TheSavior review this when you can, please. |
Fix emit error. Wrong parameters Remove commented out log.
|
Can you resolve the conflicts? |
|
grr. Some help needed: How do I squish or rebase commits that aren't mine so I'm left with just my commits? |
|
@chrisle easier to clone the project again, copy over your files and open another PR, imho. |
|
Yeah.. i was starting to think that. OK.. hold on. |
|
Please disregard this pull request. The merge went south. See PR 2913 instead for cleaner pull request. |
|
You can rebuild your local branch and force push it to github instead of opening a new pr Also used rebase -i to squash the commits |
7 participants
Short Description:
Update
MoveToMapPokemonto use events instead of logger. Same as PR 2867 but includes documentation and a refactor of the module.Fixes: