Added string format to step_walker#3587
Closed
guitared wants to merge 1 commit intoPokemonGoF:devfrom
Closed
Conversation
|
@guitared, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @TheSavior and @asnelzin to be potential reviewers |
Contributor
|
I don't think this is the right fix. This should only be printed out in debug mode, but it is getting printed even when not in debug mode. @douglascamata how do we fix this? |
|
@TheSavior I think this is because of the coloured_logging_handler using sys.stdout.write and the 'level' parameter being passed through isn't being used at all. |
Member
|
The coloured logging handler should be fixed to use the logging module correctly as the normal logging handler uses. |
Member
|
#3637 will fix this properly by fixing the coloured log handler implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description:
Added string format for location in step_walker.py