Skip to content

Comments

Added string format to step_walker#3587

Closed
guitared wants to merge 1 commit intoPokemonGoF:devfrom
guitared:dev
Closed

Added string format to step_walker#3587
guitared wants to merge 1 commit intoPokemonGoF:devfrom
guitared:dev

Conversation

@guitared
Copy link

Short Description:

Added string format for location in step_walker.py

@mention-bot
Copy link

@guitared, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @TheSavior and @asnelzin to be potential reviewers

@elicwhite
Copy link
Contributor

I don't think this is the right fix. This should only be printed out in debug mode, but it is getting printed even when not in debug mode. @douglascamata how do we fix this?

@ryanb93
Copy link

ryanb93 commented Aug 11, 2016

@TheSavior I think this is because of the coloured_logging_handler using sys.stdout.write and the 'level' parameter being passed through isn't being used at all.

@douglascamata
Copy link
Member

The coloured logging handler should be fixed to use the logging module correctly as the normal logging handler uses.

@douglascamata
Copy link
Member

#3637 will fix this properly by fixing the coloured log handler implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants