Skip to content

Comments

tweaked encrypt.so instructions#3648

Closed
jrjhealey wants to merge 2 commits intodevfrom
PokemonGo-Bot-Wiki
Closed

tweaked encrypt.so instructions#3648
jrjhealey wants to merge 2 commits intodevfrom
PokemonGo-Bot-Wiki

Conversation

@jrjhealey
Copy link

Tweaked wget command and tidied up some english

@mention-bot
Copy link

@jrjhealey, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @devn0ll and @nivong to be potential reviewers


Ensure you are in the PokemonGo-Bot main folder and run:

`wget http://pgoapi.com/pgoencrypt.tar.gz && tar -xf pgoencrypt.tar.gz && cd pgoencrypt/src/ && make && mv libencrypt.so ../../encrypt.so`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me,
if you put it all together don't you want to go up the 2 folders ? with and &&cd ../../ in the end ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's probably a good shout!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wget will not work on Mac. Curl is needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please reference to the setup.sh file instead of this (I think it's setup.sh -e)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will need to add a second instruction in that case, I was just tidying up what was there for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second instruction @jrjhealey? And @devn0ll what do u mean? What part

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nivong ah never mind
(btw if you need encryp for linux its already in the linux manuel install thing)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nivong by second I mean 'alternative', or even just a line to tell OSX users to substitute curl in for wget. To be honest it's not clear to me exactly if we're even going to keep this part of the docu since it's handled in setup.sh(?) now - but while it's there I figure it should be maintained.

Depends what you think?

Copy link
Contributor

@bruvv bruvv Aug 11, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli bit?

@bruvv
Copy link
Contributor

bruvv commented Aug 11, 2016

Please for future editing and prs please link to setup.sh (I think it's setup.sh -e)

We don't have the copyright of encrypt.so, please grab from internet and build your self.Take the risk as your own.
Example build sequence:
Create a new separate folder some here
Due to copywrite on the encrypt.so we are not directly hosting it. Please find a copy elsewhere on the internet and compile it yourself. We accept no responsibility should you encounter any problems with files you download elsewhere.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dammit I put copyright first then talked myself in to thinking it was wrong! Haha

@bruvv
Copy link
Contributor

bruvv commented Aug 12, 2016

wget http://pgoapi.com/pgoencrypt.tar.gz && tar -xf pgoencrypt.tar.gz && cd pgoencrypt/src/ && make && mv libencrypt.so ../../encrypt.so && cd ../..`
Remove this and link to setup

@bruvv
Copy link
Contributor

bruvv commented Aug 12, 2016

I have merged this into mine. please close. #3593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants