Skip to content

Comments

Force setup.sh to use python2#3702

Closed
Adrenocortico wants to merge 1 commit intoPokemonGoF:devfrom
Adrenocortico:dev
Closed

Force setup.sh to use python2#3702
Adrenocortico wants to merge 1 commit intoPokemonGoF:devfrom
Adrenocortico:dev

Conversation

@Adrenocortico
Copy link

Short Description:

Force setup.sh to use python2

@mention-bot
Copy link

@Adrenocortico, thanks for your PR! By analyzing the annotation information on this pull request, we identified @simonsmh, @kestel and @nivong to be potential reviewers

@bruvv
Copy link
Contributor

bruvv commented Aug 12, 2016

#3662
By forcing the script to use a python2 executable you're restricting the way people can install Python. Python compiles by default to python executable, so we should use it. A simple code can be added to bot's initialization to identify the Python version and exit with a warning is on Python 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants