More variance to step_walker#3857
More variance to step_walker#3857mjmadsen wants to merge 17 commits intoPokemonGoF:devfrom mjmadsen:dev
Conversation
Added 10% speed variance (speed in config = max). Added random_lat_long_delta to location if we are close.
|
@mjmadsen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @tstumm and @douglascamata to be potential reviewers |
|
@mjmadsen the speed variance needs to be configurable. |
|
@douglascamata Changes applied. |
|
The speed should be +/- not just -. You can achieve this with |
| def step(self): | ||
| if (self.dLat == 0 and self.dLng == 0) or self.dist < self.speed: | ||
| self.api.set_position(self.destLat, self.destLng, 0) | ||
| self.api.set_position(self.destLat + random_lat_long_delta(), self.destLng + random_lat_long_delta(), 0) |
There was a problem hiding this comment.
human_behavior.py
I figured it would be better if we didn't move to the exact stop coord.
|
@DiegoRBaquero We can switch to +/- variance. My thought is walk is the max speed and we sometimes go slower than that. We could also switch to having a walk_max, walk_min and fetch a speed somewhere in there. |
|
I'd prefer a min-max setting rather than a variance. I'm searching for a good distribution to use. @mjmadsen you commited while I was typing <3 |
|
@DiegoRBaquero Give me a bit and we should have a working setup for walk_min and walk_max in place of walk. I wasted too much time only to realize that distance_unit is only for display purposes and has no effect on the walk unit. I need to diff merged stuff since I got off work. Soon. |
|
I am new to git and having merge troubles. I'm going to shut this down and reopen after corrections. |
4 participants
Switched walk to walk_max and walk_min
Removed unnecessary parameters in function calls
Added variance if target location is within range (do not land directly on pokestop)