recycle items in cascading#3929
Closed
developerllazy wants to merge 1 commit intoPokemonGoF:masterfrom
developerllazy:master
Closed
recycle items in cascading#3929developerllazy wants to merge 1 commit intoPokemonGoF:masterfrom developerllazy:master
developerllazy wants to merge 1 commit intoPokemonGoF:masterfrom
developerllazy:master
Conversation
|
@developerllazy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @BriceSD and @xc-mezcal to be potential reviewers |
Member
|
@developerllazy Definitely something we want to have ! |
Member
|
@developerllazy if you got issues to do so, don’t hesitate to pm me on slack (@thyle) |
Contributor
|
Similar PR trying to solve the same thing: #3135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note (you may remove this section before opening your PR):
We receive lots of PRs and it is hard to give proper review to PRs. Please make it easy on us by following these guidelines:
master. Please make sure your pull request is aimed atdev.config.jsonexample files.Short Description:
Enhance the recycle function so that it will consider the total number in a category. If set to keep the maximum of balls as 100. When the total balls excess 100, it will recycle Pokeball, then Greatball, then Ultraball. This function can apply to pokeball, berries, potions & revives
Fixes (provide links to github issues if you can):