Skip to content

Comments

recycle items in cascading#3929

Closed
developerllazy wants to merge 1 commit intoPokemonGoF:masterfrom
developerllazy:master
Closed

recycle items in cascading#3929
developerllazy wants to merge 1 commit intoPokemonGoF:masterfrom
developerllazy:master

Conversation

@developerllazy
Copy link
Contributor

Please Note (you may remove this section before opening your PR):

We receive lots of PRs and it is hard to give proper review to PRs. Please make it easy on us by following these guidelines:

  1. We do not accept changes to master. Please make sure your pull request is aimed at dev.
  2. If you changed a bunch of files (that aren't config files) or multiple workers to implement your feature, it probably won't get proper attention. Please split it up into multiple, smaller, more focused, and iterative PRs if you can.
  3. If you are adding a config value to something, make sure you update the appropriate config.json example files.

Short Description:

Enhance the recycle function so that it will consider the total number in a category. If set to keep the maximum of balls as 100. When the total balls excess 100, it will recycle Pokeball, then Greatball, then Ultraball. This function can apply to pokeball, berries, potions & revives

Fixes (provide links to github issues if you can):

@mention-bot
Copy link

@developerllazy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @BriceSD and @xc-mezcal to be potential reviewers

@BriceSD
Copy link
Member

BriceSD commented Aug 14, 2016

@developerllazy Definitely something we want to have !
But we don’t accept PR in master. Please make an other one in dev

@BriceSD BriceSD closed this Aug 14, 2016
@BriceSD
Copy link
Member

BriceSD commented Aug 14, 2016

@developerllazy if you got issues to do so, don’t hesitate to pm me on slack (@thyle)

@elicwhite
Copy link
Contributor

Similar PR trying to solve the same thing: #3135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants