Randomized Walkspeed

[BreezeRo]

Randomizes walk speed between 1% and config.walk_offset_percent_max if config.walk_random = true

[mention-bot]

@breezelo, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @douglascamata and @Quantra to be potential reviewers

[mjmadsen]

#3943 is similar. I would appreciate input.

[mjmadsen]

@jimmywarting the initial code used a fraction to alter set walking speed. Per a request, I switched to a max and min setup.

[BreezeRo]

Matter of preference I suppose, figured this was the shortest and cleanest way to do it, it would work in either case though the min/max step walk values in #3943 are good as well. In this case 1% is the minimum

[mjmadsen]

You could remove the bool and just have folks set percentage to 0 if they do not want variance - but you'd need to make the minimum variance percentage 0.

[BreezeRo]

I set the minimum to 1% since we are using a switch in the config for true/false ("walk_random", true), if set to false it's back to default (0)

[BreezeRo]

imported the random module since importing just the function wasn't enough (for uniform)

[elicwhite]

This might not be necessary now that #3943 has been merged. I'll let you guys decide and @breezelo, please close this PR if not necessary anymore.

[Quantra]

I prefer the flat import random because it makes using the functions like random.uniform() or random.choice() more obvious what they are. Other files in this project do from random import uniform then uniform()

[BreezeRo]

Just saw @TheSavior, will close in about ~4 hours, just want to see if anyone else has any input on this one - I'm satisfied with #3943

[Quantra]

@breezelo There's more than one way to solve most problems =]

in #3943
walk_min = 2
walk_max = 4

is the same as in here
walk = 200
walk_offset_percent_max = 0.02

Live dangerously I want to set my walk to 200 =P

[BreezeRo]

@Quantra
That's because there is a mistake here, should of been

self.speed = speed + speed * random.uniform(0.01, self.bot.config.walk_offset_percent_max) ;) updated