* replacing MoveToMap hardcoded min time config for chasing pokemon w…#4013
Closed
mvrska wants to merge 1 commit intoPokemonGoF:devfrom
mvrska:dev
Closed
* replacing MoveToMap hardcoded min time config for chasing pokemon w…#4013mvrska wants to merge 1 commit intoPokemonGoF:devfrom mvrska:dev
mvrska wants to merge 1 commit intoPokemonGoF:devfrom
mvrska:dev
Conversation
…ith more sophisticated decision whether the destination is reachable with current walk speed in time
|
@Raiven66, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mhdasding, @chrisle and @bixuanzju to be potential reviewers |
| continue | ||
|
|
||
| # pokemon not reachable with current walking speed | ||
| if pokemon['dist'] > ((pokemon['expire'] - now) * self.bot.config.walk): |
There was a problem hiding this comment.
config.walk changed to walk_max, walk_min in the latest merged PR #3943
Contributor
Author
|
thanks will check and debug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description: