User configurable delay when spinning fort#4050
Closed
Quantra wants to merge 2 commits intoPokemonGoF:masterfrom
Closed
User configurable delay when spinning fort#4050Quantra wants to merge 2 commits intoPokemonGoF:masterfrom
Quantra wants to merge 2 commits intoPokemonGoF:masterfrom
Conversation
|
@Quantra, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @sinap and @TheSavior to be potential reviewers |
|
Why not have a special humanpauseconfig.json with all pause and let config.json small ? |
Contributor
Author
|
@MZorzy I think all task related config should be set in the task's config. I don't want to look somewhere else in the config or another file. |
Member
|
@Quantra You made a PR in master, open an other one in dev please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description:
_Needs example configs updating & docs_
This PR allows the user to set min and max time spent spinning a pokestop and replaces the previous 2 second pause.
With #3872 and #4048 everything should have a user configurable delay in it's own task config.