Revert "Change log color for UpdateLiveStats and UpdateLiveInventory"#4288
Closed
Revert "Change log color for UpdateLiveStats and UpdateLiveInventory"#4288
Conversation
|
@breezelo, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alexyaoyang, @extink and @eevee-github to be potential reviewers |
Contributor
|
@breezelo Sure, I'm open to suggestions from others. For myself, setting the interval to 120 and magenta color works very well. |
Contributor
Author
|
solid point, I just noticed update stats are off by default anyway, no problem 💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4230
it was too bright and too spammy in magenta color, perhaps the default live stat update timer should be set higher (like 1 minute), or using a different color