abandon-lured-pokemons-when-not-enough-pokeball

[leanhdaovn]

• Abandon lured pokemons when there's not enough pokeball
• Refactor code for checking remaining pokeball quantity

[mention-bot]

@leanhdaovn, thanks for your PR! By analyzing the annotation information on this pull request, we identified @pokepal, @xc-mezcal and @RedViper9 to be potential reviewers

[mjmadsen]

Note commit 695ca70 no longer uses catch_visible_pokemon.py and catch_lured_pokemon.py. There is also a ball check. But now that I say that, I don't know if we're updating balls after attempts.

[leanhdaovn]

I think that commit works just fine @mjmadsen.
Only the edge case of min_ultraball_to_keep for vip pokemons hasn't been handled.

[k4n30]

@leanhdaovn not only is there merge conflicts that needs resolving, but you have made significant changes to base task which IMHO is bad as no other tasks that are pulling from base task need these changes and will need testing against all those who inherit from base task.

You should move all your changes to the function of which you are trying to fix, which is in this case the "catch pokemon" worker which merged catch lured and catch visible pokemon recently.

@Quantra Are you planning on doign the rest of the deprecation of catch lured, and catch visible files as they are going to cause issues. My suggestion is to fully deprecate them, rather than allow users to use both options depending on their config, as changes will need to be made to both options

[leanhdaovn]

@k4n30 I think we can close this PR since the commit @mjmadsen mentioned above addressed the problem