Merged
Conversation
Provides the ability to use a lucky egg before evolve_all. This will maximize xp gain.
Contributor
|
@douglascamata had commit a walk logic refactor. We are currently reviewing on it. this commit may need rebase after that commit merged. |
pokemongo_bot/__init__.py
Outdated
|
|
||
| # Pop lucky egg before evolving to maximize xp gain | ||
| if self.config.use_lucky_egg: | ||
| if self.item_inventory_count(Item.ITEM_LUCKY_EGG.value) > 0: |
There was a problem hiding this comment.
self.item_inventory_count(Item.ITEM_LUCKY_EGG.value)
Store this as a variable and then combined these two If statements into one.
Contributor
|
👍 |
pokemongo_bot/__init__.py
Outdated
| logger.log('[#] Using lucky egg ... you have {}' | ||
| .format(self.item_inventory_count(Item.ITEM_LUCKY_EGG.value))) | ||
| response_dict_lucky_egg = self.use_lucky_egg() | ||
| if response_dict_lucky_egg and \ |
There was a problem hiding this comment.
this if statement doesnt have to be on multiple lines
|
@codybaldwin I reviewed your code please take a look |
Contributor
|
Very glad to merge this one ! |
MFizz
pushed a commit
to MFizz/PokemonGo-Bot
that referenced
this pull request
Jul 29, 2016
* Lucky Egg - Evolve All Provides the ability to use a lucky egg before evolve_all. This will maximize xp gain. * Revert "Lucky Egg - Evolve All" This reverts commit abfdb59. * Lucky Egg - Evolve All * Prepare the branch update. (PokemonGoF#750)
hoanghuynh
pushed a commit
to hoanghuynh/PokemonGo-Bot
that referenced
this pull request
Sep 28, 2016
* Added fields to pokéstop webhook data * Added optional data (gyms + non-lured pokéstops) to webhooks. * Typo in comments * Fixed remaining "forts" reference + moved CLI to config * Config args without CLI w/ configargparse... * My implementation. Read PR comments for details. fuckityolo that data needs to be sent somehow. even though i hate more env variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description:
Provides the ability to use a lucky egg before evolve_all. This will maximize xp gain.
Fixes:
*note: this is my second pull request for this feature. Old repo became corrupt so had to delete/refork.