Multiple Config File Support#771
Conversation
Adds ability to drop config files into the 'configs' dir whilst developing and have them ignored by git
|
Does it support run bot with multiple configs as once? |
|
The bot can currently use any .json file to run, all this PR will do is move all the configs to a 'configs' directory and have your commits ignore them, while still not ignoring the example configs. |
|
we are going to make changes to config.json and release_config.json. once those are updated, please review this PR again and make the updates necessary for it to work. |
|
Even with changes, this PR shouldn't affect anything but help developers test on different configs. I can make changes accordingly once we merge the config files if it does affect anything |
.gitignore
Outdated
| #Multiple config | ||
| configs/ | ||
| !configs/config.json.example | ||
| !configs/release_config.json.example No newline at end of file |
There was a problem hiding this comment.
shouldn't the config examples be added to the commits ?
There was a problem hiding this comment.
That's what this does. Ignore the config directory, but allow the two example files.
There was a problem hiding this comment.
but you dont comit in the config and example files, you just delete them from directory with this PR
There was a problem hiding this comment.
Oooops! I thought I had moved those two to the configs folder for his PR. If I did that could we move forward with this PR?
There was a problem hiding this comment.
I think once you have both your files in the configs folder I don't see why we couldn't merge
There was a problem hiding this comment.
@ColeGreenlee adding a warning for people so they move their config.json files to the new directory would be pretty good as well.
Like trying to open it on configs directory first and if not there adding a Warning print "config.json not found, please add one to the configs directory"
There was a problem hiding this comment.
Added warnings in latest commit. Thanks for the suggestion!
|
Okay, example files have been re-included. Was just a missing * form the .gitignore 👍 |
|
Added the warnings as suggested. Is this PR good to go? |
|
waiting for a second review but it should be good to go ! |
|
+1 |
|
Thanks! |
|
@ColeGreenlee can I ask for another PR with information about new folder for config files in README? |
|
Yeah, I'd be more than happy to document this. |
|
Please do document this. What are the arguments for running configs from this /configs/ folder |
* Multiple Config File Support Adds ability to drop config files into the 'configs' dir whilst developing and have them ignored by git * Modified .gitignore * Fixed Example files not being included * Added warnings to PokeCLI based on config availability
7 participants
Adds ability to drop config files into the 'configs' dir whilst developing and have them ignored by git