Skip to content

Comments

A few typo fixes and improvements#782

Merged
tstumm merged 1 commit intoPokemonGoF:masterfrom
AdaptCharm:patch-7
Jul 25, 2016
Merged

A few typo fixes and improvements#782
tstumm merged 1 commit intoPokemonGoF:masterfrom
AdaptCharm:patch-7

Conversation

@AdaptCharm
Copy link
Contributor

@AdaptCharm AdaptCharm commented Jul 25, 2016

Improved version of README.md

@dmateusp
Copy link
Contributor

+1

1 similar comment
@eggins
Copy link
Contributor

eggins commented Jul 25, 2016

+1

@eggins
Copy link
Contributor

eggins commented Jul 25, 2016

👍

Approved with PullApprove

@tstumm tstumm merged commit 32cefee into PokemonGoF:master Jul 25, 2016
hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this pull request Sep 28, 2016
…m marker upgrades (PokemonGoF#782)

* Added gym levels to marker icons

Relocated code for determining gym levels to a new function getGymLevel()

* Gym Level Markers

* Compressed changed files (4.9kb ->1.4kb)

* Fixed ternary operator order

You guys are right. I didn't even think of it

* Made the gymPrestige array a global variable

Made gymPrestige a global variable as opposed to a local variable in the event that other features use this data in the future (such as PokemonGoF#666)

* Add gym style option

* Choose between gym marker styles

* lint fix

* Reorganized forts for multiple gym styles

* Reload icons on demand

Used to wait until a mapUpdate(), but that could take up to 5 seconds

* Fixed lint error

* Lossless and optimized large versions

Original large version had heavy artifacts and were not compressed.

Harmony: 35.7KB -> 20.2KB
Instinct: 17.6KB -> 10.1KB
Mystic: 27.4KB -> 11.6KB
Valor: 29.0KB -> 13.9KB
Uncontested: 43.2KB -> 14.6KB

* High-res gym markers for mobile

When viewing on mobile, the images get enlarged in order to have the same "size" as when viewing on the desktop, resulting in blurry images

* High-res gym markers for mobile

Same thing as the ingame markers

* Load and scale back a higher res version

Mobile users will be able to load the markers without them being blurry

* Whoops, didn't realize stats used these too

* Changed default gym marker to in-game

* Resize icons based on higher res icons

* Revert default gym markers back to shield

* Forgot these

Somehow I forgot to upload these when I added the css for #arenaList :/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants