Keep best CP pokemon

[koper89]

Short Description:
Couldn't test it cause dev branch cannot find me any pokemons, but hopes it'll work.

[koper89]

if not self._check_if_higher_cp_pokemon(pokemon_name, cp):

•  return True
  

in here should be False

and tested on master works fine.

[glenncampioni]

The logic seems correct, I'll test it in my patched dev branch

[glenncampioni]

Maybe we would want the default value to be False, so nothing changes for users who pull but don't update their release_config.json file?

[koper89]

Yep but in dev branch there's no more realeae congig as separate file

[glenncampioni]

You're right. This just caused quite a few errors :)

[koper89]

Doesn't seem like issue with my addition

On 26 Jul 2016 12:33 am, "Calcyfer" notifications@github.com wrote:

Currently getting this error :

pokemon_catch_worker.py", line 338, in _get_catch_config_for
catch_config = self.config.catch.get(pokemon)

AttributeError: 'Namespace' object has no attribute 'catch'

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#880 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLvD1_1sinLv-Ih5VxEy3poMVoOGvFHks5qZUflgaJpZM4JUmNL
.

[glenncampioni]

It's not, that's why I removed the comment - damn all these commits.

Works great on dev btw, after fixing the issues with the config created by other commits.

[koper89]

Great to hear.

On 26 Jul 2016 1:01 am, "Calcyfer" notifications@github.com wrote:

It's not, that's why I removed the comment - damn all these commits.

Works great on dev btw, after fixing the issues with the config created by
other commits.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#880 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLvD3G5jJ_5JbLnqw3xcKrtozZK7Sziks5qZU5TgaJpZM4JUmNL
.

[Nihisil]

👍

I hope you have enough patience to merge all dev changes into your branch and that you will not give up with this pull-request.

[slimjim2234]

LGTM!
👍

[j-waaang]

Suggestion: It should keep lower cp pokemon in case it has very good iv otherwise I'm gonna loose all my perfekt pokemons.

[koper89]

#953
Moved to this pull.