Skip to content

Comments

Added a progress bar for walking.#970

Merged
solderzzc merged 1 commit intoPokemonGoF:devfrom
x1024:dev
Jul 26, 2016
Merged

Added a progress bar for walking.#970
solderzzc merged 1 commit intoPokemonGoF:devfrom
x1024:dev

Conversation

@x1024
Copy link
Contributor

@x1024 x1024 commented Jul 26, 2016

There's now a TTY-only progress bar when walking from one place to another.

It doesn't show up when the program's output is piped to a file, or if it's run as a daemon.
I could use some help with testing on different OS/shell combinations.

@tstumm
Copy link
Contributor

tstumm commented Jul 26, 2016

Have you tested that? Cause im pretty sure it wont work, because StepWalker lives like only step long.

Otherwise that would be pretty cool.

@x1024
Copy link
Contributor Author

x1024 commented Jul 26, 2016

I have tested it, this is how it looks for me:

screenshot

@ZgrK
Copy link
Contributor

ZgrK commented Jul 26, 2016

So nice idea.

@ZgrK
Copy link
Contributor

ZgrK commented Jul 26, 2016

I have tested it also, looks so cool 👍
screen shot 2016-07-26 at 2 17 12 pm

@tstumm
Copy link
Contributor

tstumm commented Jul 26, 2016

Yep you're right, I misinterpreted the code... Looks very nice. Have you tried what happens if pokemon appears while walking?

@x1024
Copy link
Contributor Author

x1024 commented Jul 26, 2016

If you encounter something unexpected, there is no line break:

screenshot

I haven't yet thought too much about how to fix that. Maybe a simple "if we're in a tty, print a line break" in front of every line that can interrupt a walk?

@solderzzc
Copy link
Contributor

@x1024 Good suggestion, Let's merge here before conflict happen. save time for rebase.

@solderzzc solderzzc merged commit c5af117 into PokemonGoF:dev Jul 26, 2016
@KLVN
Copy link
Contributor

KLVN commented Jul 26, 2016

Buggy on my Win 10 machine, maybe because of a different language format (german)?
[ÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûêÔûê ] 39%

@x1024
Copy link
Contributor Author

x1024 commented Jul 26, 2016

@KLVN it uses the "square block" character, for esthetic reasons. It could be changed to a simple "=" or "+" sign.
Perhaps someone can suggest a square block character that is locale-independent?

@x1024 x1024 deleted the dev branch July 26, 2016 18:31
@LuckyMe4Evers
Copy link
Contributor

Screen is full of it
screenshot050

@bimahp
Copy link
Contributor

bimahp commented Jul 26, 2016

imho a simple "=" is sufficient for me

@KLVN
Copy link
Contributor

KLVN commented Jul 26, 2016

@x1024 Let's use "=" then. Isn't that beautiful as a full block, but it works. :)
pokegopath

@JohnnyOmm
Copy link

JohnnyOmm commented Jul 28, 2016

I'm new to github. how do I download your step_walker.py

edit: I tried just copying and pasting raw codes and making a .py but I get this error when I run it

C:\PokeGoBot Dev\PokemonGo-Bot>step_walker.py
Traceback (most recent call last):
  File "C:\PokeGoBot Dev\PokemonGo-Bot\step_walker.py", line 3, in <module>
    from cell_workers.utils import distance, i2f
ImportError: No module named cell_workers.utils

MFizz pushed a commit to MFizz/PokemonGo-Bot that referenced this pull request Jul 29, 2016
MFizz pushed a commit to MFizz/PokemonGo-Bot that referenced this pull request Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants