Skip to content

Comments

Dump cells to enable more front-end features#995

Closed
depau wants to merge 1 commit intoPokemonGoF:masterfrom
depau:celldump
Closed

Dump cells to enable more front-end features#995
depau wants to merge 1 commit intoPokemonGoF:masterfrom
depau:celldump

Conversation

@depau
Copy link

@depau depau commented Jul 26, 2016

Short Description:
It now dumps the cell list as a json into data/cells-$username.json, so that more front-ends can use this information (I'm working on a Kivy-based one).

@depau depau changed the title also dump cells to enable more front-end features Dump cells to enable more front-end features Jul 26, 2016
@fredrik-hellmangroup
Copy link
Contributor

i assume cells becomes inactive after X amount of time, would i then suggest to add a checker to remove old cells during program execution

@depau
Copy link
Author

depau commented Jul 26, 2016

Cells are provided by the API, I assume the API knows better what cells are inactive. Also, by using this patch with my program, I can tell you that this happens, as new pokestops appear automatically and "used" ones get marked.

There's no need to do any check, and, anyways, it's not related to what this pull-request adds. It just dumps the existing in-memory information to disk for other programs to use.

By the way, this is the program that uses it: https://github.com/Davideddu/PokeVy

@solderzzc
Copy link
Contributor

please sub pr to our dev branch, we need only PR to dev to make thing easy.
Let me close this one, waiting for PR on dev.

@solderzzc solderzzc closed this Jul 26, 2016
@depau
Copy link
Author

depau commented Jul 26, 2016

Okay, thank you. I see there have been a lot of changes, I'll read the code and re-implement it.

@depau
Copy link
Author

depau commented Jul 26, 2016

Submitted. #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants