Skip to content

multifix#102

Merged
angeousta merged 4 commits intomainfrom
test
Jul 11, 2023
Merged

multifix#102
angeousta merged 4 commits intomainfrom
test

Conversation

@lorenzocorallo
Copy link
Copy Markdown
Member

  • downloaded 2021 rankings from original source to gain "matricola"
  • fix [BUG] reparsing non funziona correttamente #91: re-parsing was not working (the function to Add and Merge the ranking to the set was not correctly handling the re-parsing)
  • fix: temporary removed parallel in Parser methods because it was causing random data loss (need further investigation)
  • refactor: merit and course creation moved to their own functions and simplified "matricola" discrimination
  • finally fix [BUG] discrepanza tra immat.consentita e immat.corso #86 and discrepanza tra immat.consentita e immat.corso Rankings#84
  • fix: for some reason rankings urls were including \\ instead / and it was braking the compare method
  • fix: LinksFind.GetCombinationLinks now searches starting from 2021 (latest year online with "matricola" at the time the script was made)
  • fix: canEnrollinto on course tables without "matricola" pointing to meritTable now are set to the courseTitle (I think that it was already done, but the script wasn't doing that, so idk)

@lorenzocorallo lorenzocorallo requested a review from angeousta July 11, 2023 21:19
@angeousta angeousta merged commit f512925 into main Jul 11, 2023
@angeousta angeousta deleted the test branch July 11, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] reparsing non funziona correttamente [BUG] discrepanza tra immat.consentita e immat.corso

2 participants