Skip to content

Refactor3 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angeousta merged 5 commits into from
Aug 14, 2023
Merged

Refactor3 #145

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5945056
Update .gitignore
invalid-email-address Aug 14, 2023
d5f17c5
Update RankingUrl.cs
invalid-email-address Aug 14, 2023
d9b4a9a
Update RankingUrl.cs
invalid-email-address Aug 14, 2023
7ff4df1
Update RankingUrl.cs
invalid-email-address Aug 14, 2023
f286819
Revert "Update .gitignore"
invalid-email-address Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions PoliNetwork.Graduatorie.Common/Objects/RankingNS/RankingUrl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,26 @@ namespace PoliNetwork.Graduatorie.Common.Objects.RankingNS;

[Serializable]
[JsonObject(MemberSerialization.Fields, NamingStrategyType = typeof(CamelCaseNamingStrategy))]
public class RankingUrl
public class RankingUrl : IComparable<RankingUrl>, IEquatable<RankingUrl>
{
public PageEnum PageEnum = PageEnum.Unknown;
public string Url = "";

public int CompareTo(RankingUrl? other)
{
if (ReferenceEquals(this, other)) return 0;
if (ReferenceEquals(null, other)) return 1;
var pageEnumComparison = PageEnum.CompareTo(other.PageEnum);
return pageEnumComparison != 0 ? pageEnumComparison : string.Compare(Url, other.Url, StringComparison.Ordinal);
}

public bool Equals(RankingUrl? other)
{
if (other == null)
return false;
return PageEnum == other.PageEnum && Url == other.Url;
}

public override bool Equals(object? obj)
{
if (obj is not RankingUrl rankingUrl) return false;
Expand All @@ -29,11 +44,6 @@ public override int GetHashCode()
return PageEnum.GetHashCode() ^ urlHash;
}

protected bool Equals(RankingUrl other)
{
return PageEnum == other.PageEnum && Url == other.Url;
}


public int GetHashWithoutLastUpdate()
{
Expand All @@ -48,7 +58,7 @@ public int GetHashWithoutLastUpdate()
/// </summary>
/// <param name="url">
/// The full url string
/// prefered input -> http://www.risultati-ammissione.polimi.it/2022_20064_html/2022_20064_generale.html
/// preferred input -> http://www.risultati-ammissione.polimi.it/2022_20064_html/2022_20064_generale.html
/// valid case -> /2022_20064_html/2022_20064_generale.html
/// </param>
/// <returns>RankingUrl</returns>
Expand Down