feat: add RankingOrder to SingleCourseJson (for indexes)#153
Merged
lorenzocorallo merged 1 commit intomainfrom Nov 10, 2023
Merged
feat: add RankingOrder to SingleCourseJson (for indexes)#153lorenzocorallo merged 1 commit intomainfrom
lorenzocorallo merged 1 commit intomainfrom
Conversation
This was referenced Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behaviour
Frontend: when the user select the School and the Year, all the rankings of that selection are loaded to be divided in the correct phases (like "Prima Fase", "Extra-UE").
This is wrong, because the ranking file should be loaded only once the user has chosen to view that specific ranking.
Fix
Add the field
RankingOrdertoSingleCourseJsonso that the phase can be recognized without loading the specific ranking file but directly from the Index file.