Skip to content

fix: fill RankingOrder in SingleCourseJson #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angeousta merged 2 commits into from
Jul 4, 2024
Merged

fix: fill RankingOrder in SingleCourseJson #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28a5cee
feat: make Ranking IComparable for List Sort
lorenzocorallo Jul 4, 2024
9044d4b
fix: fill RankingOrder in SingleCourseJson
lorenzocorallo Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion PoliNetwork.Graduatorie.Parser/Objects/Json/Indexes/Specific/BySchoolYearCourseJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ private static SingleCourseJson CreateCourseJson(Ranking ranking, CourseTable co
BasePath = basePath,
Year = ranking.Year,
School = ranking.School,
Location = course.Location
Location = course.Location,
RankingOrder = ranking.RankingOrder
};
}

Expand Down
10 changes: 9 additions & 1 deletion PoliNetwork.Graduatorie.Parser/Objects/RankingNS/Ranking.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace PoliNetwork.Graduatorie.Parser.Objects.RankingNS;

[Serializable]
[JsonObject(MemberSerialization.Fields, NamingStrategyType = typeof(CamelCaseNamingStrategy))]
public class Ranking
public class Ranking : IComparable<Ranking>
{
public List<CourseTable>? ByCourse;
public MeritTable? ByMerit;
Expand All @@ -35,6 +35,14 @@ public RankingSummaryStudent GetRankingSummaryStudent()
return new RankingSummaryStudent(RankingOrder?.Phase, School, Year, Url);
}

public int CompareTo(Ranking? other)
{
if (ReferenceEquals(this, other)) return 0;
if (ReferenceEquals(null, other)) return 1;

return string.Compare(GetId(), other.GetId(), StringComparison.Ordinal);
}


/***
* Ottieni l'hash senza considerare il valore di LastUpdate
Expand Down