chore: inspect code#169
Merged
lorenzocorallo merged 12 commits into105-refactor-param-mutationfrom Jul 7, 2024
Merged
Conversation
52 tasks
Contributor
Author
|
questa pr è per te @lorenzocorallo |
Contributor
Author
|
se la approvi fai |
angeousta
added a commit
that referenced
this pull request
Jul 7, 2024
* refactor: BySchoolYearCourseJson * refactor: merge EnrollUtil into EnrollType * refactor: rename method in HashMatricola * refactor: rename method in Parser/Program.cs * refactor: rename param in UpdateDateFound * chore: remove unused import * refactor: move ranking saving to RankingsSet and Ranking * chore: remove fake-null param * refactor: BySchoolYearJson.cs * fix code related to merge * refactor: ByYearSchoolJson.cs * chore: remove orphan nullable attribute from RankingsSet params * refactor: StatsJson.cs + rename StatsSingleJson.cs method * refactor: StatsSchool.cs * refactor: StatsYear.cs * refactor: rename WriteToFile to Write for consistency * refactor: StatsJson.cs and related * hotfix: distinct SingleCourseJson in BySchoolYearJson.All * hotfix: same distinct as BySchoolYearJson for other indexes * fix: remove Location from Distinct if not necessary * refactor: remove unused Ranking methods * refactor: remove unused RankingOrder method * refactor: RankingsSet.cs * chore: format RankingSummary.cs * refactor: HashMatricoleWrite.cs * chore: compact class init and method call * refactor: RankingSummaryStudent.cs * refactor: StudentHashSummary.cs * refactor: Scraper/Program.cs * refactor: CheckUrlUtil.cs * refactor: ScraperOutput.cs * chore: remove unused import * chore: inspect code (#169) * Update IndexJsonBase.cs, OutputWriteUtil.cs, and Converter.cs * Update Lib_CSharp * Update Ranking.cs * Update BySchoolYearJson.cs * Update StatsSchool.cs and StatsYear.cs * Update Ranking.cs * Update RankingsSet.cs * Update RankingsSet.cs, CourseTable.cs, and HashMatricoleWrite.cs * Update BySchoolYearCourseJson.cs, StatsSchool.cs, Ranking.cs, and 2 more files * Update EnrollType.cs, IndexJsonBase.cs, BySchoolYearJson.cs, and 4 more files * Update BySchoolYearCourseJson.cs, SingleCourseJson.cs, StatsYear.cs, and 5 more files * fix: check saved ranking before saving (#170) --------- Co-authored-by: userbot_github <actions@github.com> Co-authored-by: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com> --------- Co-authored-by: angeousta <132761637+angeousta@users.noreply.github.com> Co-authored-by: userbot_github <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.