Skip to content

fix: do not recreate group if redis is empty #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorenzocorallo merged 7 commits into from
Apr 17, 2026
Merged

fix: do not recreate group if redis is empty #114

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
82355b3
fix: do not recreate group if redis is empty
toto04 Apr 14, 2026
d603eec
fix: fixed the fix
toto04 Apr 14, 2026
4ee3241
fix: add ttl
toto04 Apr 14, 2026
18d42f8
perf: fill redis once to avoid too many backend calls
lorenzocorallo Apr 17, 2026
eaa809a
Merge branch 'main' into fix-redis
lorenzocorallo Apr 17, 2026
691d6a9
fix: remove ttl, otherwise we lose track
lorenzocorallo Apr 17, 2026
82282ec
fix: void the fillRedis promise
lorenzocorallo Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/middlewares/bot-membership-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,14 @@ export class BotMembershipHandler<C extends TelemetryContextFlavor<Context>> ext
constructor() {
super("bot_membership_handler")

void this.fillRedis()

// TEMP: this is for initial migration from previous bot
this.composer.fork().filter(predicate, async (ctx, next) => {
if (ctx.chat.type === "private") return next()

const redisCheck = await this.TEMP_redis.has(ctx.chat.id.toString())
if (redisCheck) {
const backendGroup = await api.tg.groups.getById.query({ telegramId: ctx.chat.id }).catch(() => null)
if (backendGroup !== null) return next()
}
if (redisCheck) return next()

const me = await ctx.getChatMember(ctx.me.id).catch(() => ({ status: "undefined" }))
if (me.status !== "administrator") {
Expand Down Expand Up @@ -93,6 +92,11 @@ export class BotMembershipHandler<C extends TelemetryContextFlavor<Context>> ext
})
}

private async fillRedis() {
const dbGroups = await api.tg.groups.getAll.query()
await Promise.all(dbGroups.map((g) => this.TEMP_redis.write(g.telegramId.toString(), g.telegramId)))
}

private static isJoin<C extends Context>(ctx: MemberContext<C>): boolean {
const oldStatusCheck = ["left", "kicked"].includes(ctx.myChatMember.old_chat_member.status)
const newStatusCheck = joinEvent[ctx.myChatMember.chat.type].includes(ctx.myChatMember.new_chat_member.status)
Expand Down
Loading