Skip to content

feat: check if bot is admin before group management #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toto04 merged 2 commits into from
Apr 11, 2026
Merged

feat: check if bot is admin before group management #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05474d4
feat: check if bot is admin before group management
lorenzocorallo Apr 11, 2026
9961402
fix: typo
lorenzocorallo Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/lib/group-management/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,17 @@ async function errorBackend(chat: ChatFullInfo, type: "CREATE" | "UPDATE", fatal
type GroupDB = Parameters<TRPCClient<AppRouter>["tg"]["groups"]["create"]["mutate"]>[0][0]
export const GroupManagement = {
async create(chatId: number, addedBy: User): Promise<Result<GroupDB, string>> {
const { status } = await modules.shared.api
.getChatMember(chatId, modules.shared.botInfo.id)
.catch(() => ({ status: null }))
if (status !== "administrator") {
const reason = "The bot is not an administrator"
logger.error({ chatId, reason }, "[GroupManagement] Cannot CREATE group")
return err(reason)
}

const chat = await modules.shared.api.getChat(chatId).catch(() => null)

if (!chat) {
const reason = "The bot cannot retrieve chat info, probably it is not an administrator"
logger.error({ chatId, reason }, "[GroupManagement] Cannot CREATE group")
Expand Down Expand Up @@ -79,6 +89,15 @@ export const GroupManagement = {
},

async update(chatId: number, requestedBy: User): Promise<Result<GroupDB, string>> {
const { status } = await modules.shared.api
.getChatMember(chatId, modules.shared.botInfo.id)
.catch(() => ({ status: null }))
if (status !== "administrator") {
const reason = "The bot is not an administrator"
logger.error({ chatId, reason }, "[GroupManagement] Cannot UPDATE group")
return err(reason)
}
Comment thread
lorenzocorallo marked this conversation as resolved.

const chat = await modules.shared.api.getChat(chatId).catch(() => null)
if (!chat) {
const reason = "The bot is not in this group or is not an administrator"
Expand Down
Loading