Skip to content

New Jersey TANF Demographic Eligible #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xudonglai0426 wants to merge 4 commits into from
Closed

New Jersey TANF Demographic Eligible #2174

xudonglai0426 wants to merge 4 commits into from

Conversation

@xudonglai0426
Copy link
Collaborator

@xudonglai0426 xudonglai0426 commented Apr 24, 2023 •
edited by ghost
Loading

Fixes #2172

Co-authored-by: VioletChen0916 VioletChen0916@users.noreply.github.com

🤖 Generated by Copilot at 078b0a0

Summary

📝🆕📐

This pull request adds two new variables to the policy engine model, nj_is_demographic_tanf_eligible and nj_is_person_demographic_tanf_eligible, to implement the demographic eligibility criteria for New Jersey TANF. It also updates the changelog entry to reflect the new feature.

New feature for TANF
nj_is_person_ checks age
Fall school enrollment

Walkthrough

  • Add two new variables for New Jersey TANF eligibility based on demographic criteria (link, link)
  • Update the changelog entry to indicate the new feature (minor bump) related to New Jersey TANF (link)

@xudonglai0426 @VioletChen0916
New Jersey TANF Demographic Eligible
078b0a0 
Fixes PolicyEngine#2172

Co-authored-by: VioletChen0916 <VioletChen0916@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bc2009b) 97.17% compared to head (944b1a3) 97.17%.

❗ Current head 944b1a3 differs from pull request most recent head 8a543d1. Consider uploading reports for the commit 8a543d1 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2174   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files        1252     1254    +2     
  Lines       19828    19849   +21     
  Branches      164      164           
=======================================
+ Hits        19268    19289   +21     
  Misses        534      534           
  Partials       26       26
Impacted Files Coverage Δ
...s/nj/njdhs/tanf/nj_is_demographic_tanf_eligible.py 100.00% <100.00%> (ø)
...dhs/tanf/nj_is_person_demographic_tanf_eligible.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xudonglai0426
Copy link
Collaborator Author

xudonglai0426 commented Apr 24, 2023

https://www.state.nj.us/humanservices/providers/grants/public/publicnoticefiles/NJ%20TANF%20State%20Plan%20FFY%2021%20-%20FFY%2023%20DRAFT.pdf#page=13

@xudonglai0426 xudonglai0426 marked this pull request as ready for review April 24, 2023 18:20
@xudonglai0426 xudonglai0426 marked this pull request as draft April 26, 2023 14:38
xudonglai0426 and others added 3 commits April 26, 2023 11:44
@xudonglai0426 xudonglai0426 marked this pull request as ready for review April 28, 2023 15:02
leogoldman
leogoldman reviewed May 26, 2023
View reviewed changes
Copy link
Collaborator

@leogoldman leogoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my own understanding, do we have the nj_is_demographic_tanf_eligible variable (as opposed to just using the one with the formula) for consistency with other states?

policyengine_us/variables/gov/states/nj/njdhs/tanf/nj_is_person_demographic_tanf_eligible.py
Comment on lines +16 to +17
child_under_18 = person("age", period) < 18
is_under_19 = person("age", period) < 19
Copy link
Collaborator

@leogoldman leogoldman May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would give us more flexibility if we made these ages (18 and 19) parameters like child_age_eligible and student_age_eligible

...s/tests/policy/baseline/gov/states/nj/njdhs/tanf/nj_is_person_demographic_tanf_eligible.yaml
Comment on lines +3 to +5
input:
age: 17
output:
Copy link
Collaborator

@leogoldman leogoldman May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add is_full_time_student: false so that each test contains both the formula inputs

@nikhilwoodruff nikhilwoodruff force-pushed the master branch 2 times, most recently from 7926ec9 to d2543dc Compare July 12, 2025 15:13
@hua7450
Copy link
Collaborator

hua7450 commented Jan 7, 2026

Consolidated into #7123

@hua7450 hua7450 closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGhenis MaxGhenis MaxGhenis left review comments

@leogoldman leogoldman leogoldman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Jersey TANF Demographic Eligible

4 participants

@xudonglai0426 @hua7450 @MaxGhenis @leogoldman