Conversation
Tests verify that policyengine-us works with pandas 3.0 changes: - State-based parameter lookups (StringArray handling) - String-typed variables (filled_array with StringDtype) - Enum variables These tests require policyengine-core >= 3.9.1 which has the pandas 3 fixes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7233 +/- ##
============================================
- Coverage 100.00% 75.80% -24.20%
============================================
Files 12 3687 +3675
Lines 205 53026 +52821
Branches 0 263 +263
============================================
+ Hits 205 40196 +39991
- Misses 0 12769 +12769
- Partials 0 61 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Input variable for weeks looking for work during the year. Sourced from CPS ASEC variable LKWEEKS. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove pandas <3.0 cap to allow pandas 3.0.0 - Add tests that directly test policyengine-core's: - filled_array handling of pandas StringDtype - VectorialParameterNodeAtInstant handling of StringArray These tests will FAIL until policyengine-core >= 3.9.1 is released with the pandas 3 compatibility fixes. This demonstrates TDD - the tests catch the bug when the fix is not present. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
policyengine-core 3.23.4 includes fixes for: - filled_array handling of pandas StringDtype - VectorialParameterNodeAtInstant handling of StringArray Tests should now pass with pandas 3.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
policyengine-core 3.23.5 includes the fix for KeyError when encoding Enum variables with pandas 3.0 StringDtype index. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was accidentally included in the pandas 3.0 PR. Removing to get Quick Feedback tests to pass (the new variable was triggering full test suite instead of selective tests). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
These tests require policyengine-core >= 3.9.1 which has the pandas 3 compatibility fixes (merged in PolicyEngine/policyengine-core#424).
🤖 Generated with Claude Code