Skip to content

Base arch structure#20

Merged
WilliamHarvey97 merged 12 commits intomasterfrom
base-arch-structure
Sep 25, 2020
Merged

Base arch structure#20
WilliamHarvey97 merged 12 commits intomasterfrom
base-arch-structure

Conversation

@WilliamHarvey97
Copy link
Copy Markdown
Contributor

Comment thread mobile/lib/test/widget_test.dart
Comment thread mobile/lib/src/app.dart
@abelfodil
Copy link
Copy Markdown
Contributor

Tested on android emulator and doesn't crash.

LGTM

@MouradLachhab
Copy link
Copy Markdown
Contributor

I was reading through the bloc doc, and I was wondering if we were going to use the bloc tests ? If so, we would need to add these to pubspec.yaml.
test: ^1.3.0
bloc_test: ^7.0.0

@WilliamHarvey97
Copy link
Copy Markdown
Contributor Author

I was reading through the bloc doc, and I was wondering if we were going to use the bloc tests ? If so, we would need to add these to pubspec.yaml.
test: ^1.3.0
bloc_test: ^7.0.0

Will we really test our blocs/cubits? I tought a little bit about it and I told myself that the most important thing to test is our domain layer since it is there that the app business logic will be concentrated

@WilliamHarvey97 WilliamHarvey97 merged commit f55a290 into master Sep 25, 2020
@WilliamHarvey97 WilliamHarvey97 deleted the base-arch-structure branch September 25, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants