Merged
Conversation
Contributor
WilliamHarvey97
commented
Sep 19, 2020
- Create a project example using this arch https://github.com/PolyCortex/polydodo/wiki/Mobile-Architecture
- Add some important dependencies
…base-arch-structure
abelfodil
reviewed
Sep 19, 2020
abelfodil
reviewed
Sep 19, 2020
Contributor
|
Tested on android emulator and doesn't crash. LGTM |
abelfodil
approved these changes
Sep 23, 2020
Contributor
|
I was reading through the bloc doc, and I was wondering if we were going to use the bloc tests ? If so, we would need to add these to pubspec.yaml. |
Contributor
Author
Will we really test our blocs/cubits? I tought a little bit about it and I told myself that the most important thing to test is our domain layer since it is there that the app business logic will be concentrated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.