Merged
Conversation
…base-arch-structure
MouradLachhab
requested review from
WilliamHarvey97,
abelfodil,
conorato and
mateobelanger
abelfodil
reviewed
Sep 29, 2020
conorato
reviewed
Oct 1, 2020
| @@ -0,0 +1,27 @@ | |||
| import 'package:flutter_blue/flutter_blue.dart'; | |||
|
|
|||
| abstract class BluetoothStates {} | |||
Contributor
There was a problem hiding this comment.
Justement, à y repenser, FlutterBlue ne devrait normalement pas être importé dans les blocs. Ce package devrait être utilisé pour aller chercher l'information dans une méthode d'une repository. Ce repository pourra alors retourner un objet du domaine qui est en lien avec la carte d'acquisition choisie.
Pour la liste des prospects de devices, on pourrait probablement juste renvoyer une dataclass ProspectDevice de List IDeviceRepository::discover(). C'est alors cette méthode discover qui pourrait utiliser flutter blue et scan les devices. Finalement, notre couche applicative pourra utiliser la méthode pour obtenir la list des ProspectDevice qui sera affiché. Lorsqu'on en sélectionne un, on peut ensuite l'utiliser dans la méthode Device IDeviceRepository::connect(ProspectDevice prospectDevice). Device correspondra alors à un objet du modèle avec son comportement.
WilliamHarvey97
requested changes
Oct 3, 2020
WilliamHarvey97
requested changes
Oct 3, 2020
Contributor
WilliamHarvey97
left a comment
WilliamHarvey97
left a comment
There was a problem hiding this comment.
L'app ne roule pas sur l'emulateur
Unhandled Exception: PlatformException(bluetooth_unavailable, the device does not have bluetooth, null, null)
added 2 commits
October 3, 2020 17:04
… perform formating on dart files.
WilliamHarvey97
requested changes
Oct 3, 2020
…fmt as dart formatter
abelfodil
reviewed
Oct 3, 2020
…nto repository, and small formatting changes)
generic entity extending equatable with unique id
abelfodil
approved these changes
Oct 8, 2020
WilliamHarvey97
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for feedback on basically anything you think should be changed. (Naming convention, structure, order of functions, bloc implementation.