Convert hexadecimal file to decimal & feature extraction#32
Merged
Convert hexadecimal file to decimal & feature extraction#32
Conversation
Contributor
Author
|
rename |
conorato
changed the title
Contributor
Author
abelfodil
requested changes
Oct 19, 2020
Contributor
abelfodil
left a comment
abelfodil
left a comment
There was a problem hiding this comment.
Overall big brain stuff
Juste quelques commentaires sur la forme, sinon ça me semble correct
abelfodil
requested changes
Oct 19, 2020
WilliamHarvey97
requested changes
Oct 20, 2020
Contributor
WilliamHarvey97
left a comment
WilliamHarvey97
left a comment
There was a problem hiding this comment.
Super! Ça avance bien. Il ne manque plus qu'un dernier allez-retour au notebook et cela devrait être bon.
abelfodil
requested changes
Oct 20, 2020
Co-authored-by: Anes Belfodil <abelfodil@users.noreply.github.com>
…ing (before or after epoch)
…do into backend/classification
…do into backend/classification
…on has already checked that and returned error otherwise
abelfodil
approved these changes
Oct 22, 2020
WilliamHarvey97
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes work to