Switch from flutter_blue to flutter_reactive_ble#35
Merged
MouradLachhab merged 13 commits intomasterfrom Oct 12, 2020
Merged
Conversation
MouradLachhab
requested review from
WilliamHarvey97,
abelfodil,
conorato and
mateobelanger
abelfodil
requested changes
Oct 11, 2020
abelfodil
requested changes
Oct 11, 2020
abelfodil
reviewed
Oct 11, 2020
abelfodil
reviewed
Oct 11, 2020
abelfodil
reviewed
Oct 11, 2020
abelfodil
requested changes
Oct 11, 2020
Contributor
abelfodil
left a comment
abelfodil
left a comment
There was a problem hiding this comment.
This code seems to disconnect the device, so we should preserve the stream value and use it to disconnect by cancelling the stream elsewhere.
abelfodil
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch was made to flutter reactive ble framework allowing to set the BLE priority which drops the packet loss considerably. However, this framework does not provide methods to disconnect a connected device. Error handling was also changed, I'm not sure if this is the best way to do it.