Merged
Conversation
…base-arch-structure
…nto repository, and small formatting changes)
generic entity extending equatable with unique id
MouradLachhab
requested review from
WilliamHarvey97,
abelfodil,
conorato and
mateobelanger
abelfodil
requested changes
Oct 14, 2020
| } | ||
|
|
||
| _serialPort.setPortParameters( | ||
| 115200, UsbPort.DATABITS_8, UsbPort.STOPBITS_1, UsbPort.PARITY_NONE); |
Contributor
There was a problem hiding this comment.
Optionnel, il y a moyen de setup le device à 921600 baud/s
| import 'package:polydodo/src/infrastructure/constants.dart'; | ||
| import 'baseTransformer.dart'; | ||
|
|
||
| class CytonTransformer<S, T> extends BaseTransformer<S, T> { |
Contributor
There was a problem hiding this comment.
Optionnel, unit test this class and ganglion
Contributor
Author
There was a problem hiding this comment.
Added Unit tests, not sure I'm liking the way it's done tho, Open to feedback.
abelfodil
requested changes
Oct 18, 2020
Contributor
abelfodil
left a comment
abelfodil
left a comment
There was a problem hiding this comment.
En général faut éviter les side-effects (garder les fonctions pures), ça rend le code plus dumb et donc plus facile à suivre.
De plus, il faut favoriser les fonctions built-in plutôt que d'écrire du code soi-même. In the words of a wise man: https://github.com/kelseyhightower/nocode
abelfodil
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Serial repository and Cyton transformer. Will need to dynamically change them with Bluetooth when changing from Cyton to Ganglion.