Merged
Conversation
added 17 commits
October 9, 2020 00:54
…mock-data-backend
…mock-data-integration-to-web
WilliamHarvey97
commented
Oct 18, 2020
WilliamHarvey97
commented
Oct 18, 2020
WilliamHarvey97
commented
Oct 18, 2020
Closed
Contributor
abelfodil
requested changes
Oct 18, 2020
Contributor
abelfodil
left a comment
abelfodil
left a comment
There was a problem hiding this comment.
Le nouveau design est sick :O
Good job overall!
Co-authored-by: Anes Belfodil <abelfodil@users.noreply.github.com>
added 5 commits
October 18, 2020 19:15
…ydodo into mock-data-integration-to-web
WilliamHarvey97
commented
Oct 19, 2020
| <Button | ||
| className="mt-4" | ||
| color="secondary" | ||
| href={`data:text/json;charset=utf-8,${encodeURIComponent(JSON.stringify(data.epochs))}`} |
Contributor
Author
There was a problem hiding this comment.
C'est ici pour download le fichier
Contributor
There was a problem hiding this comment.
maybe put it in a variable to self-document it?
abelfodil
requested changes
Oct 19, 2020
Contributor
abelfodil
left a comment
abelfodil
left a comment
There was a problem hiding this comment.
Vraiment mineur, à part ça lgtm
| <Button | ||
| className="mt-4" | ||
| color="secondary" | ||
| href={`data:text/json;charset=utf-8,${encodeURIComponent(JSON.stringify(data.epochs))}`} |
Contributor
There was a problem hiding this comment.
maybe put it in a variable to self-document it?
abelfodil
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of files were modified because they were moved or their parent folder has been renamed.
Main changes performed:
Code is hard to understand because we lack of state management. However, it should be the entire bit of logic our app will hold...