Merged
Conversation
…base-arch-structure
abelfodil
previously approved these changes
Oct 25, 2020
Contributor
|
The exception seems to come from here: |
Contributor
Author
Yea, I've looked into it, and the latest commit for that file was exactly to fix an issue with the thread not stopping when the port was closing: But I'm still not sure how I'm supposed to deal with this. As of right now, simply opening the port and closing it right after will trigger this exception. Note: This exception doesn't crash the app or really have any other consequence, but I don't feel like something like that should be in the app if it can be avoided. |
WilliamHarvey97
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a request for Cyton system status to make sure it is available when connecting.
Note: I have noticed that when closing by usb_serial port, I get a java.lang.InterruptedException. I have tried to catch that error or find how to avoid it without success, so if you have any idea.