Skip to content

Automatically create draft release#53

Merged
abelfodil merged 3 commits intomasterfrom
release
Oct 30, 2020
Merged

Automatically create draft release#53
abelfodil merged 3 commits intomasterfrom
release

Conversation

@abelfodil
Copy link
Copy Markdown
Contributor

@abelfodil abelfodil commented Oct 28, 2020 •
edited
Loading

The first part of this PR:

  • Automatically creates a draft release whenever there's a push on master
  • Fills it with the pending (between previous and new release) PRs
  • Adds mobile and server builds

Here's a published release and a draft (unpublished) release. Note that no element in the draft release has been added manually (including the title).

The second part of this PR:

  • Fetches the latest release
  • Displays a list of downloadable assets on the server download page

The download page looks like this :

image

@abelfodil abelfodil marked this pull request as draft October 28, 2020 17:36
@abelfodil abelfodil force-pushed the release branch 10 times, most recently from ca62afb to 77aff82 Compare October 28, 2020 19:04
abelfodil
abelfodil commented Oct 28, 2020
View reviewed changes
Comment thread web/src/views/analyze_sleep/waiting_for_server/index.js Outdated
@abelfodil abelfodil force-pushed the release branch 10 times, most recently from ced5d13 to b0fbaa6 Compare October 29, 2020 01:54
@abelfodil abelfodil marked this pull request as ready for review October 29, 2020 02:00
WilliamHarvey97
WilliamHarvey97 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@WilliamHarvey97 WilliamHarvey97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean!

Maybe we should add a wiki page to document all this good work! 👍

Comment thread .github/workflows/backend.yml Outdated
Comment thread .github/workflows/backend.yml Outdated
Comment thread .github/workflows/backend.yml Outdated
Comment thread .github/workflows/mobile.yml Outdated
Comment thread web/src/requests/latest_release.js Outdated
@abelfodil abelfodil merged commit 67cfcaf into master Oct 30, 2020
@abelfodil abelfodil deleted the release branch October 30, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamHarvey97 WilliamHarvey97 WilliamHarvey97 approved these changes

@mateobelanger mateobelanger Awaiting requested review from mateobelanger

@conorato conorato Awaiting requested review from conorato

@MouradLachhab MouradLachhab Awaiting requested review from MouradLachhab

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abelfodil @WilliamHarvey97