Skip to content

Backend/model integration#55

Merged
conorato merged 26 commits intomasterfrom
backend/model-integration
Nov 4, 2020
Merged

Backend/model integration#55
conorato merged 26 commits intomasterfrom
backend/model-integration

Conversation

@conorato
Copy link
Copy Markdown
Contributor

@conorato conorato commented Oct 29, 2020

Summary

This PR includes:

  • changes to use the downloaded model from our storage in order to make predictions
  • code to download the hidden markov model (hmm) parameters from our storage
  • modifications as to how we check if the model is up to date. We now also check if the latest modification was made after the time the model or matrix was modified in the storage. What lead to this modification is that the files containing the parameters for the HMM model will most likely have the same size. Indeed, even if we retrain and change the parameters, the matrices or vector will have the same dimensions (either N_STAGE x N_STAGE, or N_STAGE elements) and the float size of each parameter will stay the same.
  • Fixed a bug in the preprocessing steps, which led to all W predictions. Our training dataset is composed of raw EEG stored in EDF files. This file format stores, by default, amplitudes in Volts, and this scale was not changed afterwards. Thus, the prediction pipeline expects data to be in V, not in uV (which was the case in the backend before).

To verify

We should check if the generated server can be executed with and without the onnxruntime's dependancy, OpenMP.

@conorato conorato marked this pull request as ready for review November 1, 2020 19:53
@conorato conorato requested review from WilliamHarvey97 and abelfodil and removed request for abelfodil November 1, 2020 20:00
@conorato
Copy link
Copy Markdown
Contributor Author

conorato commented Nov 1, 2020

@conorato conorato changed the title [WIP] Backend/model integration Backend/model integration Nov 1, 2020
Comment thread backend/classification/load_model.py
Comment thread backend/classification/load_model.py
Copy link
Copy Markdown
Contributor

@abelfodil abelfodil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques commentaires par rapport à l'achitecture du modèle

Comment thread backend/app.py Outdated
Comment thread backend/classification/load_model.py Outdated
Comment thread backend/classification/config/constants.py Outdated
Comment thread backend/classification/predict.py Outdated
Comment thread backend/classification/predict.py Outdated
Comment thread backend/classification/postprocess.py Outdated
@conorato conorato requested a review from abelfodil November 4, 2020 05:15
@conorato conorato merged commit c864278 into master Nov 4, 2020
@conorato conorato deleted the backend/model-integration branch November 4, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants