Created Basic History and Night stats page#58
Merged
MouradLachhab merged 8 commits intomasterfrom Nov 5, 2020
Merged
Conversation
Contributor
abelfodil
requested changes
Nov 2, 2020
Contributor
abelfodil
left a comment
abelfodil
left a comment
There was a problem hiding this comment.
L'app est vraiment belle :O
J'ai quelques commentaires mineurs, mais sinon j'aime bien la division des éléments de UI.
Good job!
abelfodil
changed the base branch from
master
to
mobile/record-sleep-scaffold
abelfodil
changed the base branch from
mobile/record-sleep-scaffold
to
master
abelfodil
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Mathieu's page wasn't merged yet, there are some files that are common to his pull request, so just check the files in folders tagged with sleep_history or night_stats:
This will not be merged until Mathieu's pull request is done and his changes are merged into my branch.
Current look of the Stats page
