Skip to content

Backend/metrics#63

Merged
conorato merged 9 commits intomasterfrom
backend/metrics
Nov 7, 2020
Merged

Backend/metrics#63
conorato merged 9 commits intomasterfrom
backend/metrics

Conversation

@conorato
Copy link
Copy Markdown
Contributor

@conorato conorato commented Nov 6, 2020

Return epochs, spectrograms and some field of metadata in the classification response

@WilliamHarvey97 WilliamHarvey97 self-requested a review November 6, 2020 04:44
@WilliamHarvey97
Copy link
Copy Markdown
Contributor

WilliamHarvey97 commented Nov 6, 2020

Since I did the review IRL, nothing to say about this. From what I understand, there is only the following on our way to complete the back-end:

  • Be compatible with OpenBCI session data file AND Raw SD card file. Ensure it handles Ganglion and Cyton;
  • Compute metrics about sleep stage;
  • Tests edge cases input values to our endpoint.

I'll let @abelfodil give his go or no go

@conorato conorato marked this pull request as ready for review November 6, 2020 05:13
Copy link
Copy Markdown
Contributor

@abelfodil abelfodil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commentaires mineurs

Comment thread backend/classification/response.py Outdated
Comment thread backend/classification/request.py Outdated
@conorato conorato merged commit 815e74c into master Nov 7, 2020
@conorato conorato deleted the backend/metrics branch November 7, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants