Skip to content

Unlock the cheat code of the universe#79

Merged
abelfodil merged 3 commits intomasterfrom
performance
Nov 13, 2020
Merged

Unlock the cheat code of the universe#79
abelfodil merged 3 commits intomasterfrom
performance

Conversation

@abelfodil
Copy link
Copy Markdown
Contributor

@abelfodil abelfodil commented Nov 12, 2020

Huge performance boost

image

const streamStart = new Date(`${getValues('stream_start_date')} ${getValues('stream_start_time')}`);
const bedTime = new Date(`${getValues('bedtime_date')} ${getValues('bedtime_time')}`);
if (streamStart > bedTime) {
if (streamStart >= bedTime) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to PR, but it triggered me

Copy link
Copy Markdown
Contributor

@conorato conorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why backend/web/? I find it confusing with web/ folder. Otherwise, seems good to me!

@abelfodil
Copy link
Copy Markdown
Contributor Author

Why backend/web/? I find it confusing with web/ folder. Otherwise, seems good to me!

Hmmm pcq c'est le http server. Maybe http instead?

@abelfodil abelfodil merged commit 2ac7bb2 into master Nov 13, 2020
@abelfodil abelfodil deleted the performance branch November 13, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants