Merged
Conversation
MouradLachhab
requested review from
WilliamHarvey97 and
abelfodil
and removed request for
abelfodil
WilliamHarvey97
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Hive database to add persistency for sleep sequence stats. You can see in the sleep_sequence_repository.dart that I had to add an ignore for some linting issue. Somehow if I used var instead of the full list, the app would crash. because it wouldn't cast from dynamic to the right type. I investigate further, but if you have any idea that would be nice.