webpack config: add support for bootstrap 4 beta 2#71
Closed
baldychristophe wants to merge 1 commit intomasterfrom
Closed
webpack config: add support for bootstrap 4 beta 2#71baldychristophe wants to merge 1 commit intomasterfrom
baldychristophe wants to merge 1 commit intomasterfrom
Conversation
Bootstrap is dependent on jQuery and Popper, so they must be provided explicitly by webpack. This commit includes a new plugin to webpack to fixe a problem related to jQuery and according to the configuration example provided here: http://getbootstrap.com/docs/4.0/getting-started/webpack/ The dependency on Popper should be resolved by including `bootstrap.bundle.js` instead of only `bootstrap.js` in the project imports. The bundled version of bootstrap includes popper since this pull request and should not be a problem in the future. twbs/bootstrap#23735
Contributor
|
Seems to me that this is project-specific and not related to systematic. If your project uses bootstrap, then provide jquery as you did in this PR in the project's webpack.conf.js. |
vperron
suggested changes
Jan 8, 2018
Contributor
vperron
left a comment
vperron
left a comment
There was a problem hiding this comment.
I don't approve of this since it's not useful in the general case (without bootstrap) and wouldn't work if the project doesn't use jquery.
Author
|
fine, this isn't the right place to put this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap is dependent on jQuery and Popper, so they must be
provided explicitly by webpack.
This commit includes a new plugin to webpack to fix a
problem related to jQuery and according to the configuration
example provided here:
http://getbootstrap.com/docs/4.0/getting-started/webpack/
The dependency on Popper should be resolved by including
bootstrap.bundle.jsinstead of onlybootstrap.jsin theproject imports.
The bundled version of bootstrap includes popper since this
pull request and should not be a problem in the future.
twbs/bootstrap#23735