refactor: use sdk-native types, improve error handling & modularize output#13
Merged
suhailkakar merged 13 commits intomainfrom Mar 10, 2026
Merged
refactor: use sdk-native types, improve error handling & modularize output#13suhailkakar merged 13 commits intomainfrom
suhailkakar merged 13 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
chaz-polymarket
approved these changes
Mar 10, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Broad refactor touching CLI parsing types and config/key resolution paths; behavior should be equivalent but could introduce breaking CLI arg parsing or new error surfaces if the SDK type parsing differs from the old string validators.
Overview
Switches many CLI arguments from raw
Stringparsing to SDK-native types (Address,B256,U256), removing localparse_address/parse_condition_idhelpers and simplifying request building across commands.Improves runtime configurability and error handling:
POLYMARKET_RPC_URLnow overrides the default Polygon RPC, andconfig::load_config/resolve_key/resolve_signature_typereturn structuredResulterrors instead of silently failing; related callers were updated accordingly.Refactors UX/output plumbing by centralizing error printing (
output::print_error), lazily initializing API clients inmain, and splitting the large CLOB output module into smalleroutput/clob/*modules; also normalizes wallet/setup key serialization and reuses shared USDC constants.Written by Cursor Bugbot for commit eb44c20. This will update automatically on new commits. Configure here.