Skip to content

Fix: bug fix on limit order creation #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonathanAmenechi merged 1 commit into from
Mar 1, 2022
Merged

Fix: bug fix on limit order creation #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions py_order_utils/builders/limit_order_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ def build_limit_order(self, data: LimitOrderData)-> LimitOrder:
if data.maker_asset_id is not None:
maker_asset = data.exchange_address
maker_asset_data = self.erc1155_facade.transfer_from(
data.maker_asset_address,
data.maker_address,
data.taker_address,
data.maker_asset_id,
data.maker_address,
data.taker_address,
data.maker_asset_address,
data.maker_asset_id,
data.maker_amount
)
else:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name="py_order_utils",
version="0.0.11",
version="0.0.12",
author="Jonathan Amenechi",
author_email="jonathanamenechi@gmail.com",
description="Python utilities used to generate and sign limit and market orders on Polymarket's CLOB",
Expand Down