This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Honor exclude option in build config for minify/compile#952
Merged
Honor exclude option in build config for minify/compile#952
exclude option in build config for minify/compile#952Conversation
Contributor
Author
|
Thanks to #878 @christophe-g for original idea and solution. This is a reworking of that idea to use polymer-project-config update and extensible options for compile and minify. |
|
So great to see this PR. I am looking forward to seeing a release of |
Contributor
Author
|
Awaiting a minor change in polymer-project-config to rename property from "excludes" to "exclude" |
Contributor
Author
Contributor
Author
|
polymer-project-config 3.8.1 published 🎉 -- updating PR |
… `compile` build-command options.
usergenic
requested review from
FredKSchott,
aomarks,
justinfagnani and
rictic
and removed request for
aomarks,
justinfagnani and
rictic
usergenic
changed the title
excludes option in build config for minify/compileexclude option in build config for minify/compile
justinfagnani
approved these changes
Jan 29, 2018
|
Cc: @katejeffries we should doc this as soon as it's merged/released. |
|
Tools folks should feel free to either add a bug or open a PR when this is released. |
Contributor
Author
Contributor
|
Ah, finally - thanks ; ) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a reimplementation of the work in #878 sans a command-line switch (polymer.json file required.)