-
Notifications
You must be signed in to change notification settings - Fork 4
Add Bridge to action-bar.tsx #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deployment Complete! 🌐
|
|
bugbot run verbose=true |
|
bugbot is starting with request id serverGenReqId_d5228906-129f-44a5-a9eb-924031cb2011 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Refactoring Breaks Error Handling and Execution Flow
The handleDeposit function was refactored from async (awaiting handleOnRamp()) to synchronous (using void handleOnRamp()). This change removes proper error handling, leading to unhandled promise rejections if handleOnRamp() fails. Additionally, it alters execution behavior by no longer awaiting the handleOnRamp() operation's completion, which could impact loading states or user feedback.
src/app/(pages)/pools/_components/action-bar.tsx#L26-L33
PWA/src/app/(pages)/pools/_components/action-bar.tsx
Lines 26 to 33 in 4e46ab9
| const handleDeposit = () => { | |
| if (!authenticated) { | |
| login() | |
| return | |
| } | |
| void handleOnRamp() | |
| } |
BugBot free trial expires on June 16, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
We actually handle the errors in the @use-onramp hook itself, so the bug that Bugbot is pointing seems irrelevant. Also we will refactor the state soon, and this will change. |
ottodevs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Type of change
Checklist
Screenshots or video recordings (if applicable)