Skip to content

User interface improvements #38

@ArtPoon

Description

@ArtPoon

I'm not crazy about the current command-line invocation:

python3 -m openrdp ./openrdp/tests/test_neisseria.fasta ./test.csv -cfg ./openrdp/tests/test_cfg.ini -all
  • I would much prefer to enable users to simply call openrdp as an executable script in /usr/local/bin or /home/USER/.local/bin
  • There should be a default configuration, so the user does not have to use the -cfg flag.
  • Calling the script without setting -cfg proceeds to run the analysis until it throws an exception:
Setting Up Siscan Analysis
Scanning triplet 1 / 4
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/art/git/OpenRDP/openrdp/__main__.py", line 4, in <module>
    main()
  File "/home/art/git/OpenRDP/openrdp/main.py", line 173, in main
    openrdp(infile, outfile, cfg, run_geneconv, run_three_seq, run_rdp,
  File "/home/art/git/OpenRDP/openrdp/main.py", line 146, in openrdp
    scanner.run_scans(aln)
  File "/home/art/git/OpenRDP/openrdp/scripts/run_scans.py", line 139, in run_scans
    maxchi.execute(triplet)
  File "/home/art/git/OpenRDP/openrdp/scripts/maxchi.py", line 147, in execute
    win_size = triplet.get_win_size(0, self.win_size, self.fixed_win_size, self.num_var_sites,
AttributeError: 'MaxChi' object has no attribute 'win_size'

-cfg is listed as an optional argument in the help text, so it should behave as such!

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions