fix: upgrade @hono/node-server to fix Node.js v24 crash#1605
Open
fede-kamel wants to merge 1 commit intoPortkey-AI:mainfrom
Open
fix: upgrade @hono/node-server to fix Node.js v24 crash#1605fede-kamel wants to merge 1 commit intoPortkey-AI:mainfrom
fede-kamel wants to merge 1 commit intoPortkey-AI:mainfrom
Conversation
Bump @hono/node-server from ^1.3.3 (resolved 1.13.5) to ^1.14.2 (resolved 1.19.14) to fix "Failed to find Response internal state key" error on Node.js v24. Root cause: Node v24 ships a newer Undici that changed how Response internal state is accessed. Fixed upstream in honojs/node-server#241, released in @hono/node-server@1.14.2. Closes Portkey-AI#1604
Author
|
@VisargD @narengogi Verified the fix on Node.js v24.10.0: Build + server boot: Unit tests (29/29 pass): The 6 suite failures are pre-existing on TypeScript: same 2 pre-existing errors on Before (Node v24 + @hono/node-server@1.13.5): After (Node v24 + @hono/node-server@1.19.14): This is a one-line version bump — minimal risk, high impact for anyone developing on Node v24. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1604
Summary
@hono/node-serverfrom^1.3.3(resolved 1.13.5) to^1.14.2(resolved 1.19.14)Failed to find Response internal state keyerror on Node.js v24package.json+ lockfile updateRoot Cause
Node.js v24 ships a newer version of Undici that changed how
Responseinternal state is accessed (nodejs/undici@45dceeaf). This was fixed upstream in honojs/node-server#241 and released in@hono/node-server@1.14.2.Before (Node v24)
After (Node v24)
Test Plan
npm run build— cleannode start-test.js— boots without error, exits 0handlers/services/)