Skip to content

feat: Add setup wizard integration and data-less task discovery#1745

Merged
adboio merged 1 commit intomainfrom
04-20-wizard_integration_and_first_data-less_tasks
May 5, 2026
Merged

feat: Add setup wizard integration and data-less task discovery#1745
adboio merged 1 commit intomainfrom
04-20-wizard_integration_and_first_data-less_tasks

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 20, 2026

Problem

New users had no guided path between onboarding and their first task, leaving them on a blank screen.

Changes

  1. Add SetupView with animated scan feed showing real-time agent activity during repo analysis
  2. Integrate PostHog wizard task that configures SDK integration (cloud or worktree mode)
  3. Add data-less task discovery that scans the repo for quick wins (bugs, dead code, stale flags, etc.)
  4. Wire setup flow into sidebar, navigation store and onboarding completion
  5. Add analytics events constants and tracking for setup lifecycle
  6. Add SuggestedTasks component displaying categorized discovered tasks with icons

How did you test this?

Manually

@charlesvien charlesvien changed the title Wizard integration and first data-less tasks feat: Wizard integration and first data-less tasks Apr 20, 2026
Copy link
Copy Markdown
Member Author

charlesvien commented Apr 20, 2026

@charlesvien charlesvien force-pushed the 04-14-product_tours branch from 840c97f to 6875139 Compare April 21, 2026 00:04
@charlesvien charlesvien force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch 2 times, most recently from f3c2192 to 8a1005f Compare April 21, 2026 00:43
@charlesvien charlesvien force-pushed the 04-14-product_tours branch 2 times, most recently from ae6e8c1 to c6e983b Compare April 21, 2026 01:15
@charlesvien charlesvien force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch from 8a1005f to ac96735 Compare April 21, 2026 01:15
@charlesvien charlesvien force-pushed the 04-14-product_tours branch from c6e983b to 93c4a74 Compare April 21, 2026 01:45
@charlesvien charlesvien force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch from ac96735 to 7947acc Compare April 21, 2026 01:45
@charlesvien charlesvien force-pushed the 04-14-product_tours branch from 93c4a74 to 4f0e9d2 Compare April 21, 2026 18:57
@charlesvien charlesvien force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch 2 times, most recently from 6fbd5cb to 86d906e Compare April 21, 2026 20:50
@charlesvien charlesvien force-pushed the 04-14-product_tours branch from 4f0e9d2 to e2819da Compare April 21, 2026 20:50
@charlesvien charlesvien force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch 6 times, most recently from a42521e to a1955d4 Compare April 22, 2026 03:23
Base automatically changed from 04-14-product_tours to main April 22, 2026 03:31
An error occurred while trying to automatically change base from 04-14-product_tours to main April 22, 2026 03:31
@charlesvien charlesvien force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch 5 times, most recently from d83707c to 52e0e54 Compare April 22, 2026 15:25
@charlesvien charlesvien force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch 2 times, most recently from d0d0c68 to e7dcd4a Compare April 24, 2026 15:30
@charlesvien charlesvien changed the title feat: Wizard integration and first data-less tasks feat: Add setup wizard integration and data-less task discovery Apr 24, 2026
@adboio adboio force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch 8 times, most recently from 2553f77 to c33bc3e Compare May 4, 2026 16:10
@adboio adboio marked this pull request as ready for review May 4, 2026 16:21
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 4, 2026

Prompt To Fix All With AI
Fix the following 3 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 3
apps/code/src/renderer/features/setup/services/setupRunService.ts:335-338
**Duplicate `subscribeToWizardEvents` call creates two active tRPC subscriptions**

`onTaskReady` already calls `setWizardTaskId`, `invalidateQueries`, and `subscribeToWizardEvents` when the task is ready. Because `onTaskReady` fires inside `saga.run()`, these are called again unconditionally when `saga.run()` resolves. The result is two independent polling loops both eventually calling `trpcClient.agent.onSessionEvent.subscribe` for the same `taskRunId`, so every wizard activity event is pushed to the feed twice (duplicate feed entries). The second call also overwrites `this.wizardSubscription`, leaking the first subscription until the abort signal fires. The post-`saga.run()` block should be removed; `onTaskReady` is already the correct place for this work.

```suggestion
      // onTaskReady already called setWizardTaskId / subscribeToWizardEvents;
      // nothing more to do after saga.run() resolves.
```

### Issue 2 of 3
apps/code/src/renderer/features/onboarding/stores/onboardingStore.ts:12
**`isConnectingGithub` is unused dead state**

`isConnectingGithub` is declared in the interface and initialised in `initialState`, but has no corresponding setter action, is never read anywhere in this PR, and is excluded from `partialize`. It appears to be leftover scaffolding that was never wired up. Leaving it here violates the "no superfluous parts" rule and will confuse future readers who look for where it is toggled.

### Issue 3 of 3
apps/code/src/renderer/features/onboarding/components/context-collection/SuggestedTasks.tsx:26-43
**`CATEGORY_CONFIG` duplicated across two files**

An identical `CATEGORY_CONFIG` record (mapping `DiscoveredTask["category"]` → icon + colour) exists in both `SuggestedTasks.tsx` and `DiscoveredTaskDetailPane.tsx`. If a new category is added to `DiscoveredTask`, both files need to be updated independently. Extracting the config to a shared module (e.g. `@features/setup/utils/categoryConfig.ts`) would satisfy the OnceAndOnlyOnce rule and remove the risk of the two configs drifting.

Reviews (1): Last reviewed commit: "Wizard integration and first data-less t..." | Re-trigger Greptile

Comment thread apps/code/src/renderer/features/setup/services/setupRunService.ts Outdated
Comment thread apps/code/src/renderer/features/onboarding/stores/onboardingStore.ts Outdated
@adboio adboio requested a review from a team May 4, 2026 16:32
@adboio adboio force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch 5 times, most recently from 8f6b8a4 to c67e833 Compare May 4, 2026 21:28
@adboio adboio mentioned this pull request May 4, 2026
@adboio adboio force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch from c67e833 to 8b0d42b Compare May 4, 2026 21:36
@adboio adboio force-pushed the 04-20-wizard_integration_and_first_data-less_tasks branch from 8b0d42b to e31183b Compare May 5, 2026 00:25
@charlesvien charlesvien added the Create release This will trigger a new release label May 5, 2026
Copy link
Copy Markdown
Contributor

adboio commented May 5, 2026

slack stamp from charles 🫡

@adboio adboio merged commit eeedfa0 into main May 5, 2026
16 checks passed
@adboio adboio deleted the 04-20-wizard_integration_and_first_data-less_tasks branch May 5, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create release This will trigger a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants