feat: Add setup wizard integration and data-less task discovery#1745
Merged
feat: Add setup wizard integration and data-less task discovery#1745
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 20, 2026
840c97f to
6875139
Compare
f3c2192 to
8a1005f
Compare
ae6e8c1 to
c6e983b
Compare
8a1005f to
ac96735
Compare
c6e983b to
93c4a74
Compare
ac96735 to
7947acc
Compare
93c4a74 to
4f0e9d2
Compare
6fbd5cb to
86d906e
Compare
4f0e9d2 to
e2819da
Compare
a42521e to
a1955d4
Compare
An error occurred while trying to automatically change base from
04-14-product_tours
to
main
April 22, 2026 03:31
d83707c to
52e0e54
Compare
d0d0c68 to
e7dcd4a
Compare
2553f77 to
c33bc3e
Compare
Contributor
Prompt To Fix All With AIFix the following 3 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 3
apps/code/src/renderer/features/setup/services/setupRunService.ts:335-338
**Duplicate `subscribeToWizardEvents` call creates two active tRPC subscriptions**
`onTaskReady` already calls `setWizardTaskId`, `invalidateQueries`, and `subscribeToWizardEvents` when the task is ready. Because `onTaskReady` fires inside `saga.run()`, these are called again unconditionally when `saga.run()` resolves. The result is two independent polling loops both eventually calling `trpcClient.agent.onSessionEvent.subscribe` for the same `taskRunId`, so every wizard activity event is pushed to the feed twice (duplicate feed entries). The second call also overwrites `this.wizardSubscription`, leaking the first subscription until the abort signal fires. The post-`saga.run()` block should be removed; `onTaskReady` is already the correct place for this work.
```suggestion
// onTaskReady already called setWizardTaskId / subscribeToWizardEvents;
// nothing more to do after saga.run() resolves.
```
### Issue 2 of 3
apps/code/src/renderer/features/onboarding/stores/onboardingStore.ts:12
**`isConnectingGithub` is unused dead state**
`isConnectingGithub` is declared in the interface and initialised in `initialState`, but has no corresponding setter action, is never read anywhere in this PR, and is excluded from `partialize`. It appears to be leftover scaffolding that was never wired up. Leaving it here violates the "no superfluous parts" rule and will confuse future readers who look for where it is toggled.
### Issue 3 of 3
apps/code/src/renderer/features/onboarding/components/context-collection/SuggestedTasks.tsx:26-43
**`CATEGORY_CONFIG` duplicated across two files**
An identical `CATEGORY_CONFIG` record (mapping `DiscoveredTask["category"]` → icon + colour) exists in both `SuggestedTasks.tsx` and `DiscoveredTaskDetailPane.tsx`. If a new category is added to `DiscoveredTask`, both files need to be updated independently. Extracting the config to a shared module (e.g. `@features/setup/utils/categoryConfig.ts`) would satisfy the OnceAndOnlyOnce rule and remove the risk of the two configs drifting.
Reviews (1): Last reviewed commit: "Wizard integration and first data-less t..." | Re-trigger Greptile |
8f6b8a4 to
c67e833
Compare
c67e833 to
8b0d42b
Compare
8b0d42b to
e31183b
Compare
adboio
approved these changes
May 5, 2026
Contributor
|
slack stamp from charles 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
New users had no guided path between onboarding and their first task, leaving them on a blank screen.
Changes
How did you test this?
Manually