feat(code): do not check for updates after update restart

[adboio]

Problem

we ship too fast 🤪

when i click 'restart' on an update, it's almost guaranteed that there is already another update ready as soon as the app restarts

Changes

tracks last-launched version and does not check for updates if they differ, so that restarting after an update doesn't immediately give you another one, and it just falls back to the 24hr cadence

How did you test this?

unit tests

[adboio]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(code): do not check for updates after update restart #1932 👈 (View in Graphite)
• feat(code): fix task actions menu click handler #1929
• feat(code): fix padding on command center new task UI #1927
• feat(code): fix command approval option vertical alignment #1925
• feat(code): do not show task list empty state until fetch is complete #1924
• feat(code): fix github chip margins #1923
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Prompt To Fix All With AI

This is a comment left during a code review.
Path: apps/code/src/main/services/updates/service.test.ts
Line: 285-340

Comment:
**Prefer parameterised tests**

The three scenario tests in `"initial check on startup"` share an identical structure — set `_value`, set `version`, call `initializeService`, assert on `check` and `set` — and should be collapsed into a single `it.each` table per the team's testing conventions.

```typescript
it.each([
  {
    desc: "first ever launch (no stored version)",
    storedVersion: null,
    appVersion: "1.0.0",
    expectCheck: true,
    expectSet: "1.0.0",
  },
  {
    desc: "relaunching the same version",
    storedVersion: "1.0.0",
    appVersion: "1.0.0",
    expectCheck: true,
    expectSet: null,
  },
  {
    desc: "post-update restart (version changed)",
    storedVersion: "1.0.0",
    appVersion: "1.0.1",
    expectCheck: false,
    expectSet: "1.0.1",
  },
])("$desc", async ({ storedVersion, appVersion, expectCheck, expectSet }) => {
  mockUpdatesStore._value = storedVersion;
  mockAppMeta.version = appVersion;

  await initializeService(service);

  expectCheck
    ? expect(mockUpdater.check).toHaveBeenCalled()
    : expect(mockUpdater.check).not.toHaveBeenCalled();

  if (expectSet) {
    expect(mockUpdatesStore.set).toHaveBeenCalledWith("lastLaunchedVersion", expectSet);
  } else {
    expect(mockUpdatesStore.set).not.toHaveBeenCalled();
  }
});
```

**Context Used:** Do not attempt to comment on incorrect alphabetica... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "feat(code): do not check for updates aft..." | Re-trigger Greptile}

[greptile-apps]

Prefer parameterised tests

The three scenario tests in "initial check on startup" share an identical structure — set _value, set version, call initializeService, assert on check and set — and should be collapsed into a single it.each table per the team's testing conventions.

it.each([
  {
    desc: "first ever launch (no stored version)",
    storedVersion: null,
    appVersion: "1.0.0",
    expectCheck: true,
    expectSet: "1.0.0",
  },
  {
    desc: "relaunching the same version",
    storedVersion: "1.0.0",
    appVersion: "1.0.0",
    expectCheck: true,
    expectSet: null,
  },
  {
    desc: "post-update restart (version changed)",
    storedVersion: "1.0.0",
    appVersion: "1.0.1",
    expectCheck: false,
    expectSet: "1.0.1",
  },
])("$desc", async ({ storedVersion, appVersion, expectCheck, expectSet }) => {
  mockUpdatesStore._value = storedVersion;
  mockAppMeta.version = appVersion;

  await initializeService(service);

  expectCheck
    ? expect(mockUpdater.check).toHaveBeenCalled()
    : expect(mockUpdater.check).not.toHaveBeenCalled();

  if (expectSet) {
    expect(mockUpdatesStore.set).toHaveBeenCalledWith("lastLaunchedVersion", expectSet);
  } else {
    expect(mockUpdatesStore.set).not.toHaveBeenCalled();
  }
});

Context Used: Do not attempt to comment on incorrect alphabetica... (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/main/services/updates/service.test.ts
Line: 285-340

Comment:
**Prefer parameterised tests**

The three scenario tests in `"initial check on startup"` share an identical structure — set `_value`, set `version`, call `initializeService`, assert on `check` and `set` — and should be collapsed into a single `it.each` table per the team's testing conventions.

```typescript
it.each([
  {
    desc: "first ever launch (no stored version)",
    storedVersion: null,
    appVersion: "1.0.0",
    expectCheck: true,
    expectSet: "1.0.0",
  },
  {
    desc: "relaunching the same version",
    storedVersion: "1.0.0",
    appVersion: "1.0.0",
    expectCheck: true,
    expectSet: null,
  },
  {
    desc: "post-update restart (version changed)",
    storedVersion: "1.0.0",
    appVersion: "1.0.1",
    expectCheck: false,
    expectSet: "1.0.1",
  },
])("$desc", async ({ storedVersion, appVersion, expectCheck, expectSet }) => {
  mockUpdatesStore._value = storedVersion;
  mockAppMeta.version = appVersion;

  await initializeService(service);

  expectCheck
    ? expect(mockUpdater.check).toHaveBeenCalled()
    : expect(mockUpdater.check).not.toHaveBeenCalled();

  if (expectSet) {
    expect(mockUpdatesStore.set).toHaveBeenCalledWith("lastLaunchedVersion", expectSet);
  } else {
    expect(mockUpdatesStore.set).not.toHaveBeenCalled();
  }
});
```

**Context Used:** Do not attempt to comment on incorrect alphabetica... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[jonathanlab]

Closing in favor of #1938