Conversation
Generated-By: PostHog Code Task-Id: a6ac13a7-5e32-4d39-ac72-1850b59bb9a0
Contributor
|
Reviews (1): Last reviewed commit: "feat(sidebar): open sidebar automaticall..." | Re-trigger Greptile |
DanielVisca
reviewed
Apr 30, 2026
Comment on lines
+10
to
+12
| const hasCompletedOnboarding = useOnboardingStore( | ||
| (state) => state.hasCompletedOnboarding, | ||
| ); |
There was a problem hiding this comment.
When is 'hasCompletedOnboarding' set to true ?
joshsny
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The sidebar now opens automatically when users complete onboarding, improving the post-onboarding experience by showing the sidebar by default alongside the existing behavior of opening it when workspaces exist.
Problem
After completing onboarding, users would not see the sidebar opened automatically, requiring them to manually open it. This creates a suboptimal user experience for newly onboarded users.
Changes
useOnboardingStoreimport to access onboarding completion state inMainSidebarcomponentsetOpenAutocall to open the sidebar when either:hasCompletedOnboardingto the dependency array of theuseEffecthook to ensure proper reactivityHow did you test this?
This change integrates with existing onboarding and sidebar state management. The logic ensures backward compatibility by maintaining the original behavior of opening the sidebar when workspaces exist, while adding the new condition for onboarding completion.
Publish to changelog?
no
Created with PostHog Code